Skip to content

Add RANLIB_x86_64_unknown_illumos env for dist-x86_64-illumos dockerfile #109163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add RANLIB_x86_64_unknown_illumos env for dist-x86_64-illumos dockerfile #109163

merged 1 commit into from
Mar 22, 2023
+5 −4

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Mar 15, 2023

close rust-lang/cc-rs#798

We already set AR_x86_64_unknown_illumos in the dockerfile. So it is reasonable to set the RANLIB_x86_64_unknown_illumos.

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 15, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Mar 18, 2023

📌 Commit c4939f1 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
@bors
Copy link
Collaborator

bors commented Mar 18, 2023

⌛ Testing commit c4939f1 with merge ec9c96ab88e1879d0846474ab91af9fa550e9a41...

@bors
Copy link
Collaborator

bors commented Mar 18, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 18, 2023

@bors treeclosed=100

@ehuss
Copy link
Contributor

ehuss commented Mar 18, 2023

@bors retry
Adding back to the queue, there is some segfault issue.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
This was referenced Mar 18, 2023
Merged
Merged
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-stable failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
-- LLVM_MAIN_SRC_DIR: "/checkout/src/llvm-project/llvm"
  UNSUPPORTED COMPILER-RT CONFIGURATION DETECTED: LLVM cmake package not
  found.

  Reconfigure with -DLLVM_CMAKE_DIR=/path/to/llvm.
  CMakeLists.txt:92 (load_llvm_config)


-- Attempting to mock the changes made by LLVMConfig.cmake
---
-- Could NOT find LLVM (missing: LLVM_DIR)
  UNSUPPORTED COMPILER-RT CONFIGURATION DETECTED: LLVM cmake package not
  found.

  Reconfigure with -DLLVM_CMAKE_DIR=/path/to/llvm.
  CMakeLists.txt:92 (load_llvm_config)


-- LLVM_MAIN_SRC_DIR: "/checkout/src/llvm-project/llvm"
---
  UNSUPPORTED COMPILER-RT CONFIGURATION DETECTED: LLVM cmake package not
-- Could NOT find LLVM (missing: LLVM_DIR)
  found.

  Reconfigure with -DLLVM_CMAKE_DIR=/path/to/llvm.
  CMakeLists.txt:92 (load_llvm_config)


-- LLVM_MAIN_SRC_DIR: "/checkout/src/llvm-project/llvm"
---
-- Could NOT find LLVM (missing: LLVM_DIR)
  UNSUPPORTED COMPILER-RT CONFIGURATION DETECTED: LLVM cmake package not
  found.

  Reconfigure with -DLLVM_CMAKE_DIR=/path/to/llvm.
  CMakeLists.txt:92 (load_llvm_config)


-- LLVM_MAIN_SRC_DIR: "/checkout/src/llvm-project/llvm"
---
Building stage1 library artifacts (x86_64-unknown-linux-gnu) 
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)' '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa")' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Cprefer-dynamic -Cembed-bitcode=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/1.70.0/")' --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 254)
  --- stderr
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x97e043)[0x7f450d708043]
  /lib/x86_64-linux-gnu/libc.so.6(+0x43090)[0x7f450ca15090]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libLLVM-16-rust-1.70.0-nightly.so(+0x7262e06)[0x7f450b2b2e06]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xd0fa64)[0x7f450da99a64]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbca65c)[0x7f450d95465c]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbc9794)[0x7f450d953794]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvXs5_Cs7DTEPoQIU0M_18rustc_codegen_llvmNtB5_18LlvmCodegenBackendNtNtNtCsiydnvZ3aRh1_17rustc_codegen_ssa6traits7backend14CodegenBackend15target_features+0x1b)[0x7f450d9b37cb]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util17add_configuration+0x37)[0x7f450d7f5887]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util14create_session+0x89d)[0x7f450d7f632d]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x988590)[0x7f450d712590]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x983310)[0x7f450d70d310]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x984e53)[0x7f450d70ee53]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libstd-1c2653f0407064e2.so(rust_metadata_std_65e6c9c8149d69d4+0xca4ae)[0x7f450cc924ae]
  /lib/x86_64-linux-gnu/libpthread.so.0(+0x8609)[0x7f4503e30609]
  /lib/x86_64-linux-gnu/libc.so.6(clone+0x43)[0x7f450caf1133]
  [RUSTC-TIMING] ___ test:false 0.204
  rustc exited with signal: 11 (SIGSEGV) (core dumped)

This was referenced Mar 19, 2023
Merged
Merged
@0xPoe
Copy link
Member Author

0xPoe commented Mar 21, 2023

@Mark-Simulacrum It seems the failure did not relate to my changes. Could you please help me retry it?

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

⌛ Testing commit c4939f1 with merge 439292b...

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 439292b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 22, 2023
@bors bors merged commit 439292b into rust-lang:master Mar 22, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 22, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (439292b): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.7%, 0.8%] 4
Regressions ❌
(secondary)		 0.5% [0.4%, 0.7%] 9
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [0.7%, 0.8%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.6%, 0.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.6% [-3.4%, -0.5%] 5
All ❌✅ (primary) - - 0

@rustbot rustbot added the perf-regression Performance regression. label Mar 22, 2023
@lqd
Copy link
Member

lqd commented Mar 22, 2023

This has to be noise.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

build failure of openssl-sys on illumos within rustup project
8 participants
@0xPoe @rustbot @Mark-Simulacrum @bors @ehuss @rust-log-analyzer @rust-timer @lqd